[Top] [All Lists]

Re: [TCP] Modular IPv6 support in tcpdiag

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [TCP] Modular IPv6 support in tcpdiag
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 3 Nov 2004 12:20:50 -0800
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041103094451.GA20220@xxxxxxxxxxxxxxxxxxx>
References: <20041103094451.GA20220@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 3 Nov 2004 20:44:51 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> This patch allows tcpdiag to support ipv6 work as a module when itself
> is also a module.

Any particular reason you didn't use the same config ifdef
tests we use for structure layouts?  Ie.

#if defined(CONFIG_IPV6) || defined(CONFIG_IPV6_MODULE)

I don't see the need for the special new config option.

<Prev in Thread] Current Thread [Next in Thread>