netdev
[Top] [All Lists]

Re: [TCP] Modular IPv6 support in tcpdiag

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [TCP] Modular IPv6 support in tcpdiag
From: Stephen Hemminger <shemminger@xxxxxxxx>
Date: Wed, 3 Nov 2004 09:16:09 -0800
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041103094451.GA20220@xxxxxxxxxxxxxxxxxxx>
Organization: Open Source Development Lab
References: <20041103094451.GA20220@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 3 Nov 2004 20:44:51 +1100
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Hi Dave:
> 
> This patch allows tcpdiag to support ipv6 work as a module when itself
> is also a module.
> 
> I was planning for a more extensible method but now I think the effort
> would be better directed at a new generic socket netlink interface than
> the TCP-specific tcpdiag.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

I wanted to ask why all the work to make tcp_diag a module? If it is
a module there are more possibilties of user problems. Any utilities
that expect it would then have to deal with it not being loaded as well
as the possiblity of building a kernel without it.

Perhaps there ought to be a CONFIG_INET_EMBEDDED that is for those
configurations that want more restricted and smaller networking (ie no
cache's, smaller hash tables, less sysctl options, ...)


<Prev in Thread] Current Thread [Next in Thread>