netdev
[Top] [All Lists]

[NET] Move local_bh_disable back in dev_queue_xmit

To: "David S. Miller" <davem@xxxxxxxxxxxxx>, mingo@xxxxxxx, netdev@xxxxxxxxxxx
Subject: [NET] Move local_bh_disable back in dev_queue_xmit
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 3 Nov 2004 09:54:06 +1100
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
Hi Ingo:

Your recent fix to dev_queue_xmit moved the local_bh_disable to
include stuff like skb_linearize and skb_checksum_help.  These
are potentially expensive operations.  Since they don't need to
run with preempt off, we could simply move the local_bh_enable
up instead.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Attachment: p
Description: Text document

<Prev in Thread] Current Thread [Next in Thread>