Re: [PATCH 3/3] r8169: clean up

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jon Mason <jdmason@xxxxxxxxxx> :
[...]
> Silly question, does "!!" not execute a bitwise not twice?  If not, then 
> please forgive my ignorance.

<coffee alert>
logical not: !
bitwise not: ~
</coffee>

> If so, then it is unnecessary.  But if you want something prettier, how about:
> 
>  cmd->autoneg = (status & TBINwEnable) ? AUTONEG_ENABLE : AUTONEG_DISABLE;

Ok, I take it.

--
Ueimor.