Re: [PATCH 3/3] r8169: clean up

[Francois Romieu <romieu@xxxxxxxxxxxxx>]

Jon Mason <jdmason@xxxxxxxxxx> :
> Removal of some magic numbers, unnecessary double not, and addition of "link 
> down" notification.
> 
> Signed-off-by: Jon Mason <jdmason@xxxxxxxxxx>
> 
> --- r8169.c     2004-11-02 10:37:31.035203120 -0600
> +++ r8169.c.latest      2004-11-02 10:44:01.367863536 -0600
[...]
> @@ -773,7 +775,7 @@ static void rtl8169_gset_tbi(struct net_
> 
>         status = RTL_R32(TBICSR);
>         cmd->advertising = (status & TBINwEnable) ?  ADVERTISED_Autoneg : 0;
> -       cmd->autoneg = !!(status & TBINwEnable);
> +       cmd->autoneg = status & TBINwEnable;
> 
>         cmd->speed = SPEED_1000;
>         cmd->duplex = DUPLEX_FULL; /* Always set */

drivers/net/*.c use 0/1 or AUTONEG_{EN/DIS}ABLE.

--
Ueimor