netdev
[Top] [All Lists]

Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len
From: Matt Domsch <Matt_Domsch@xxxxxxxx>
Date: Mon, 1 Nov 2004 15:59:44 -0600
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1099345849.1073.1.camel@xxxxxxxxxxxxxxxx>
References: <E1CNiOT-0008GU-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041030030936.GA25102@xxxxxxxxxxxxxxxxx> <1099163419.1039.97.camel@xxxxxxxxxxxxxxxx> <20041101044433.GA18772@xxxxxxxxxxxxxxxxx> <20041101173434.GA12437@xxxxxxxxxxxxxxxxx> <20041101202754.GA23149@xxxxxxxxxxxxxxxxxxx> <20041101203821.GA15086@xxxxxxxxxxxxxxxxx> <20041101204131.GA23277@xxxxxxxxxxxxxxxxxxx> <20041101204533.GA17279@xxxxxxxxxxxxxxxxx> <1099345849.1073.1.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Mon, Nov 01, 2004 at 04:50:49PM -0500, jamal wrote:
> My onluy comment is on use of -EOVERFLOW which i have seen only
> being used in the context of floating point computation
> (same as -EUNDERFLOW). I dont know what the right thing to return would
> be.

Actually, -EOVERFLOW appears throughout the kernel.  A couple examples:

drivers/net/ppp_generic.:ppp_read() uses it to indicate skb->len >
sizeof buffer to put the data into.

fs/stat.c:cp_new_stat() and friends
    if (stat->size > MAX_NON_LFS)
          return -EOVERFLOW;
indicates that the file size is larger than can be represented by the app.

I believe our use would be consistent.

Thanks,
Matt

-- 
Matt Domsch
Sr. Software Engineer, Lead Engineer
Dell Linux Solutions linux.dell.com & www.dell.com/linux
Linux on Dell mailing lists @ http://lists.us.dell.com

<Prev in Thread] Current Thread [Next in Thread>