Re: [patch 13/18] net/cycx_drv: replace delay_cycx() with msleep

netdev

Re: [patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_inter

To:	janitor@xxxxxxxxxxxxxx
Subject:	Re: [patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_interruptible()
From:	Jeff Garzik <jgarzik@xxxxxxxxx>
Date:	Sun, 31 Oct 2004 06:04:07 -0500
Cc:	netdev@xxxxxxxxxxx, nacc@xxxxxxxxxx, acme@xxxxxxxxxxxxxxxx
In-reply-to:	<E1CO1w4-0002YG-VR@sputnik>
References:	<E1CO1w4-0002YG-VR@sputnik>
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922

janitor@xxxxxxxxxxxxxx wrote:

-/* Delay */
-static void delay_cycx(int sec)
-{
-       set_current_state(TASK_INTERRUPTIBLE);
-       schedule_timeout(sec * HZ);
-}



this _clearly_ wants an ssleep() derivative, not msleep()

        Jeff

<Prev in Thread]	Current Thread	[Next in Thread>
[patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_interruptible(), janitor Re: [patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_interruptible(), Jeff Garzik <=

Previous by Date:	Re: [patch 15/18] net/ibmtr: replace schedule_timeout() with msleep()/msleep_interruptible(), Jeff Garzik
Next by Date:	Re: [patch 12/18] net/sb1000: replace nicedelay() with msleep_interruptible(), Jeff Garzik
Previous by Thread:	[patch 13/18] net/cycx_drv: replace delay_cycx() with msleep_interruptible(), janitor
Next by Thread:	[patch 14/18] s390/ctctty: replace schedule_timeout() with msleep_interruptible(), janitor
Indexes:	[Date] [Thread] [Top] [All Lists]