netdev
[Top] [All Lists]

Re: [KJ] Re: [patch 2.4] back port msleep(), msleep_interruptible()

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [KJ] Re: [patch 2.4] back port msleep(), msleep_interruptible()
From: Nish Aravamudan <nish.aravamudan@xxxxxxxxx>
Date: Sat, 30 Oct 2004 15:59:20 -0700
Cc: maximilian attems <janitor@xxxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, Margit Schubert-While <margitsw@xxxxxxxxxxx>, kernel-janitors@xxxxxxxxxxxxxx, mcgrof@xxxxxxxxxxxxxxxxxxxx, prism54-devel@xxxxxxxxxxx, Domen Puncer <domen@xxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, hvr@xxxxxxx
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:references; b=iNp7QaqKFbmFWCI9y2c02qURNJvpBTqIvV/jBQuA4t3B9iVWEznKjo0nmncbMAfrBzMroz55l33n1Np7CzuaWuNvstMGBmgyzQsTQ0kWGMFEJ+J85FZfdxWvyqF5MlZs2hOC9ypdJ9lp6kbJgmLSrIULrOf4S+isLyMdu0/LW+w=
In-reply-to: <41841886.2080609@xxxxxxxxx>
References: <20040923221303.GB13244@xxxxxxxxxx> <5.1.0.14.2.20040924074745.00b1cd40@xxxxxxxxxxxxxxx> <415CD9D9.2000607@xxxxxxxxx> <20041030222228.GB1456@xxxxxxx> <41841886.2080609@xxxxxxxxx>
Reply-to: Nish Aravamudan <nish.aravamudan@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 30 Oct 2004 18:41:10 -0400, Jeff Garzik <jgarzik@xxxxxxxxx> wrote:
> maximilian attems wrote:
> > diff -puN include/linux/delay.h~add-msleep-2.4 include/linux/delay.h
> > --- a/include/linux/delay.h~add-msleep-2.4    2004-10-30 22:48:46.000000000 
> > +0200
> > +++ b/include/linux/delay.h   2004-10-30 22:48:46.000000000 +0200
> > @@ -34,4 +34,12 @@ extern unsigned long loops_per_jiffy;
> >       ({unsigned long msec=(n); while (msec--) udelay(1000);}))
> >  #endif
> >
> > +void msleep(unsigned int msecs);
> > +unsigned long msleep_interruptible(unsigned int msecs);
> > +
> > +static inline void ssleep(unsigned int seconds)
> [...]
> > +static inline unsigned int jiffies_to_msecs(const unsigned long j)
> 
> > +static inline unsigned int jiffies_to_usecs(const unsigned long j)
> 
> > +static inline unsigned long msecs_to_jiffies(const unsigned int m)
> 
> 
> I'm pretty sure more than one of these symbols clashes with a symbol
> defined locally in a driver.  I like the patch but we can't apply it
> until the impact on existing code is evaluated.

More than likely much of the code cleanup that was done before I began
my patches, like removing custom msleep()s from drivers will need to
be done again, as Jeff points out.

-Nish

<Prev in Thread] Current Thread [Next in Thread>