[Top] [All Lists]

Re: Asynchronous crypto layer.

To: Eugene Surovegin <ebs@xxxxxxxxxxx>
Subject: Re: Asynchronous crypto layer.
From: Evgeniy Polyakov <johnpol@xxxxxxxxxxx>
Date: Sun, 31 Oct 2004 01:17:19 +0400
Cc: Michal Ludvig <michal@xxxxxxxx>, netdev@xxxxxxxxxxx, cryptoapi@xxxxxxxxxxxxxx
In-reply-to: <20041030203906.GC6256@xxxxxxxxxxxxxxxx>
Organization: MIPT
References: <1099030958.4944.148.camel@uganda> <1099053738.1024.104.camel@xxxxxxxxxxxxxxxx> <20041029180652.113f0f6e@xxxxxxxxxxxxxxxxxxxx> <41824D9A.3070407@xxxxxxxx> <20041029183606.0b1a0538@xxxxxxxxxxxxxxxxxxxx> <Pine.LNX.4.61.0410291636020.25667@xxxxxxxxxxxxxxxx> <20041029192741.5344ad0f@xxxxxxxxxxxxxxxxxxxx> <20041030203906.GC6256@xxxxxxxxxxxxxxxx>
Reply-to: johnpol@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Sat, 30 Oct 2004 13:39:06 -0700
Eugene Surovegin <ebs@xxxxxxxxxxx> wrote:

> On Fri, Oct 29, 2004 at 07:27:41PM +0400, Evgeniy Polyakov wrote:
> > but it was designed to be usefull only in custom MX box, 
> This is not true. I coded it using Hifn PCI card plugged in 440GP eval 
> board as well in P4 2.6 GHz box.
> Driver isn't perfect, it's quite simple, I suspended all work on it 
> because without async crypto it doesn't make a lot of sense.
> > so it has some design notes that I do not agree with.
> And they are (I know there are problems, just curious which ones you 
> "don't agree with") ? 

It supports only one card, it has very nontrivial locking, which may(I'm 
not sure after just finished diagonal review) lead to too big latencies, 
hifn_cipher() can not work with any other crypto design, I doubt it can
work with other card capabilities other then you have implemented without 
major rewrite.

I'm quite sure it is good driver for current crypto schema, but if
acrypto will be committed it could not work without complete rewrite.

> --
> Euege

        Evgeniy Polyakov

Only failure makes us experts. -- Theo de Raadt

<Prev in Thread] Current Thread [Next in Thread>