On Sat, 30 Oct 2004 18:57:20 +0200 (CEST)
Michal Ludvig <michal@xxxxxxxx> wrote:
> On Sat, 30 Oct 2004, Evgeniy Polyakov wrote:
> > On Fri, 29 Oct 2004 13:44:24 -0400 (EDT)
> > James Morris <jmorris@xxxxxxxxxx> wrote:
> > > On Fri, 29 Oct 2004, Evgeniy Polyakov wrote:
> > >
> > > > I'm pleased to announce asynchronous crypto layer for Linux kernel 2.6.
> > >
> > > Could you please resend as a patch against the latest bk snapshot?
> > >
> > > i.e. output of 'diff -purN tree-a tree-b'
> > >
> > Attached following patches:
> > Kconfig.connector.patch
> > Kconfig.crypto.patch
> > Makefile.connector.patch
> > Makefile.crypto.patch
> > acrypto.patch
> > connector.patch
> Hi Evgeniy,
> I have compiled and booted with your patches. Not too much
> playing around so far. Anyway some quick observations:
I've wrote mega block device which can work(without hang) only
with 10mb "disks", but what did you expect from midnight hack after
several Staropramen's :)
Give me several minutes to complete async_provider.c and I will post
numbers, which I expect will be the same for both sync and async
driver since I do not have neither SMP(which should benefit I believe)
nor crypto card here.
> - "rmmod simple_lb" hangs because:
> | <6>You are removing crypto load balancer simple_lb which is current and
> | default.
> | There is no other crypto load balancers. Removing is delayed untill new
> | load balancer is registered.
> Of course I can't re-add it because the module is still there. In this
> case rmmod should fail with a gentle message (-EBUSY) instead of hang. Or
> let it go if not in use.
acrypto module has parameter force_lb_remove which if is set allows to remove
last crypto load balancer.
But ut has atricky moment - since any crypto_session_alloc() may occur
asyncronously then we can not say if there are any load balancer users
without some locks. Currently if there is no any crypto load balancer, then
acrypto will catch BUG_ON().
I will think of it some more.
> - In the kernel config ACRYPTO depends on CONNECTOR, but is above it in
> the menuconfig.
> - I would choose a different directory strucrure. Instead of
> drivers/acrypto and drivers/connector I'd put the device-independent
> parrts info e.g. crypto/acrypto and the drivers (e.g. Fcrypt or PadLock)
> into drivers/crypto.
connector is independent module - it is used instead of ioctl for
diagnostic. So I think it should live in drivers/connector.
I do not have any objection against your tree schema for crypto stuff.
> - For other interested: concatenated patch with some very minor tweaks is
> at http://www.logix.cz/michal/dl/acrypto/acrypto.diff
> My changes are in mludvig.diff in the same directory.
> It applies cleanly to BitKeeper tree as well.
I totally agree with your changes, thank you.
Note: KERN_EMERG was put into dprintk to allow netconsole send this data
> Michal Ludvig
> * A mouse is a device used to point at the xterm you want to type in.
> * Personal homepage - http://www.logix.cz/michal
Only failure makes us experts. -- Theo de Raadt