netdev
[Top] [All Lists]

Re: [PATCH] unexport ei_tx_timeout

To: Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH] unexport ei_tx_timeout
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Sat, 30 Oct 2004 08:37:28 -0400
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041024131256.GC19567@xxxxxx>
References: <20041024131256.GC19567@xxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
Christoph Hellwig wrote:
not used by any module, and the API doesn't make sense as export either

next time include a signed-off-by line.

Also, the API _does_ make sense as an export, as it is a generic helper that can be plugged directly into the netdev->tx_timeout hook.

However, I applied your patch due to the first argument -- no users.

        Jeff




<Prev in Thread] Current Thread [Next in Thread>