Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr

netdev

Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len

To:	Matt_Domsch@xxxxxxxx (Matt Domsch)
Subject:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len
From:	Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date:	Sat, 30 Oct 2004 11:48:16 +1000
Cc:	netdev@xxxxxxxxxxx
In-reply-to:	<20041029215134.GA15414@xxxxxxxxxxxxxxxxx>
Organization:	Core
Sender:	netdev-bounce@xxxxxxxxxxx
User-agent:	tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))

Matt Domsch <Matt_Domsch@xxxxxxxx> wrote:
> If dev->dev_addr is zero, then the memcpy() never takes place, and the

Huh? You mean dev->addr_len? Surely the caller has to know what the
address length is to use this anyway, no?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, jamal Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu <=

Previous by Date:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch
Next by Date:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Herbert Xu
Previous by Thread:	Re: [PATCH 2.6] dev.c: clear SIOCGIFHWADDR buffer if !dev->addr_len, Matt Domsch
Next by Thread:	[2.6 patch] prism54: small prismcompat cleanup, Adrian Bunk
Indexes:	[Date] [Thread] [Top] [All Lists]