netdev
[Top] [All Lists]

Re: [PATCH] 802.1Q VLAN

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] 802.1Q VLAN
From: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Date: Sat, 30 Oct 2004 02:31:02 +0200
Cc: "'netdev@xxxxxxxxxxx'" <netdev@xxxxxxxxxxx>, "Linux 802.1Q VLAN" <vlan@xxxxxxxxxxxxxxx>, Francois Romieu <romieu@xxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>
In-reply-to: <4182DABE.7000502@xxxxxxxxxxxxxxx>
References: <41797696.9070905@xxxxxxxxxxxxxxx> <20041022214611.GA4948@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41798506.1030909@xxxxxxxxxxxxxxx> <417D675F.3000909@xxxxxxxxxxxxxxx> <4181838B.6040002@xxxxxxxxx> <41818D99.9020300@xxxxxxxxxxxxxxx> <1099038566.1813.99.camel@xxxxxxxxxxxxxxxxxx> <418281C1.9080707@xxxxxxxxxxxxxxx> <4182D44E.7070507@xxxxxxxxx> <4182DABE.7000502@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.2) Gecko/20040803
Ben Greear wrote:
Can't you also add a queue to a VLAN device?

Sure you can. This is the best solution, if you have a way of
waking up the queue.

Nice. This idea is definitely worth persuing. However, ideally we
would want to be notified when the *qdisc* queue opens up - this
is our "tx ring buffer".


Maybe the qdisc could automatically flush what it could to lower
level devices/queues whenever it was asked to enqueue a packet?
This way, waking the writers could automatically wake the various
queues under the writers.

That could be happening already, and might explain why my pktgen hacks
work.

Yes, this is what qdisc does. It just isn't good enough to have to
wait for the next packet, IMO.


-Tommy

<Prev in Thread] Current Thread [Next in Thread>