Re: [PATCH netdev-2.6 8/10] ixgb: Ethtool_ops support

["Randy.Dunlap" <rddunlap@xxxxxxxx>]

> +       
> +       if(netif_running(adapter->netdev)) {
>                 ixgb_down(adapter, TRUE);
> +               ixgb_reset(adapter);
>                 ixgb_up(adapter);
> -       }
_Many_ cases where "if(" should be "if (" (same for "for").

> +static int
> +ixgb_get_regs_len(struct net_device *netdev)
> +{
> +#define IXGB_REG_DUMP_LEN  136*sizeof(uint32_t)
> +  return IXGB_REG_DUMP_LEN;
> +}

Might as well #undef this constant if you want it to be "local".


There are several places where an if () also does an assignment
without doing a comparison.  sparse will beep/gong on those.
Have you tried sparse?  E.g.:
+               if((err = ixgb_up(adapter)))
+                       return err;
Instead of using double parens to appease gcc, do this:
                if ((err = ixgb_up(adapter) != 0)
                        return err;


--
~Randy