netdev
[Top] [All Lists]

Re: [PATCH 7/6] cls_fw: CONFIG_NET_CLS_IND is not dependant on CONFIG_NE

To: jamal <hadi@xxxxxxxxxx>
Subject: Re: [PATCH 7/6] cls_fw: CONFIG_NET_CLS_IND is not dependant on CONFIG_NET_CLS_ACT
From: Thomas Graf <tgraf@xxxxxxx>
Date: Fri, 29 Oct 2004 13:53:33 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <1099049980.1024.21.camel@xxxxxxxxxxxxxxxx>
References: <20041029002113.GY12289@xxxxxxxxxxxxxx> <20041029102620.GH12289@xxxxxxxxxxxxxx> <1099049980.1024.21.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
* jamal <1099049980.1024.21.camel@xxxxxxxxxxxxxxxx> 2004-10-29 07:39
> Thomas, Can you submit equivalent patches for cls_u32.c?

Sure, already done and queued for submission. I will submit them today.

> Thomas, I will let Dave suck these in first and test against resulting
> bk.

OK.

Regarding the generic statistics for actions:

I thought about dumping the most common stats basic,queue,rate_est
in tcf_action_copy_stats and let the action module dump additional
stats in its get_stats implementation. Any objections in creating
struct tca_act_gen with the content of tca_gen and use it to
access a->priv from act_api.c to get my hands on the statistics
and stats_lock?

<Prev in Thread] Current Thread [Next in Thread>