netdev
[Top] [All Lists]

Re: [PATCH] 802.1Q VLAN

To: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH] 802.1Q VLAN
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 27 Oct 2004 21:42:57 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <41804B35.1080306@xxxxxxxxxxxxxxx>
References: <41797696.9070905@xxxxxxxxxxxxxxx> <20041022214611.GA4948@xxxxxxxxxxxxxxxxxxxxxxxxxx> <41798506.1030909@xxxxxxxxxxxxxxx> <417D675F.3000909@xxxxxxxxxxxxxxx> <417D929A.2090809@xxxxxxxxxxxxxxx> <20041027164912.09cc63f8.davem@xxxxxxxxxxxxx> <41804B35.1080306@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 27 Oct 2004 18:28:21 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:

> > Also, what is up with the magic "23" constant in the get realdev
> > name function strncpy() call?
> 
> Well, the fields are 24-bytes long, as defined in the include/linux/if_vlan.h
> file.  I could change it to a #define and/or use sizeof if you prefer.

You could also use "sizeof(obj->member)".

<Prev in Thread] Current Thread [Next in Thread>