netdev
[Top] [All Lists]

Re: [PATCH] Add ability to register class interfaces for network class

To: "Teras Timo (EXT-YomiGroup/Helsinki)" <Ext-Timo.Teras@xxxxxxxxx>
Subject: Re: [PATCH] Add ability to register class interfaces for network class
From: ext Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Wed, 27 Oct 2004 12:13:17 +0100
Cc: ext Christoph Hellwig <hch@xxxxxxxxxxxxx>, davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041026205239.GA23825@xxxxxxxxxxxxxxxxxxxxxx>
References: <20041026183526.GA23535@xxxxxxxxxxxxxxxxxxxxxx> <20041026184838.GB16621@xxxxxxxxxxxxx> <20041026205239.GA23825@xxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.4.1i
> I pointed out the reason why I need it: to add an attribute:
> /sys/class/net/<interface>/<new_attribute>. Others might want to do this
> too.
> 
> Also the interface subsystem is used in many places (eg. i2o) to create
> all the sysfs entries. Maybe it'd be useful to do in net class as well.
> And if'd make separate interfaces for standard attributes and wireless
> attributes. That way you'd get rid of the #ifdefs of WIRELESS_EXT in
> net-sysfs.c.
> 
> On the other hand you didn't answer my question: why the
> interface registration should not be possible?
> Documentation/driver-model/interface.txt states that this is exactly the
> thing it should be used for.

Because we don't add interfaces for the sake of it. You still haven't show
the user that wants this.  i you presented a sane user the review would be
quite different.

<Prev in Thread] Current Thread [Next in Thread>