netdev
[Top] [All Lists]

Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class

To: Tommy Christensen <tommy.christensen@xxxxxxxxx>
Subject: Re: [PATCH 9/11] PKT_SCHED: Cleanup cls_set_class
From: Thomas Graf <tgraf@xxxxxxx>
Date: Wed, 27 Oct 2004 12:58:38 +0200
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, hadi@xxxxxxxxxx
In-reply-to: <20041027094238.GM12289@xxxxxxxxxxxxxx>
References: <20041026222148.GA12289@xxxxxxxxxxxxxx> <20041026222813.GJ12289@xxxxxxxxxxxxxx> <1098867450.1813.37.camel@xxxxxxxxxxxxxxxxxx> <20041027094238.GM12289@xxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
>  cls_set_class(struct tcf_proto *tp, unsigned long *clp, 
>       unsigned long cl)
>  {
>       unsigned long old_cl;
>       
> -     qdisc_lock_tree(tp->q->dev);
> -

I investigated this bug a bit more to find out why the kernel didn't
lock up during my tests and it seems this lock somehow made it into
while rediffing to split it up into multiple patches. Sorry folks
and thanks again Tommy.

<Prev in Thread] Current Thread [Next in Thread>