netdev
[Top] [All Lists]

Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used

To: Jeff Garzik <jgarzik@xxxxxxxxx>
Subject: Re: [PATCH] select appropriate skb size in tcp_sendmsg when TSO is used
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 27 Oct 2004 10:07:24 +1000
Cc: "David S. Miller" <davem@xxxxxxxxxxxxx>, thomas.spatzier@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <417EE3BB.6040902@xxxxxxxxx>
References: <OF96546AB5.ACE12043-ONC1256F33.0027BC6B-C1256F33.002D4A6E@xxxxxxxxxx> <E1CKE5P-0005SP-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041020163510.6d13e9c7.davem@xxxxxxxxxxxxx> <20041026111912.GA18095@xxxxxxxxxxxxxxxxxxx> <20041026235126.GA4733@xxxxxxxxxxxxxxxxxxx> <417EE3BB.6040902@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Tue, Oct 26, 2004 at 07:54:35PM -0400, Jeff Garzik wrote:
> Herbert Xu wrote:
> >+static int __ethtool_set_sg(struct net_device *dev, u32 data)
> >+{
> >+    int err;
> >+
> >+    if (!data && dev->ethtool_ops->set_tso) {
> >+            err = dev->ethtool_ops->set_tso(dev, 0);
> >+            if (err)
> >+                    return err;
> >+    }
> >+
> >+    return dev->ethtool_ops->set_sg(dev, data);
> >+}
> 
> you want to disable tx-csum also

IMHO it is valid to disable SG without disabling checksums, no?
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>