netdev
[Top] [All Lists]

Re: [NET] Give skb_checksum_help an sk_buff * again

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [NET] Give skb_checksum_help an sk_buff * again
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Mon, 25 Oct 2004 16:26:06 -0700
Cc: jmorris@xxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041025123507.GA4346@xxxxxxxxxxxxxxxxxxx>
References: <20041025123507.GA4346@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 25 Oct 2004 22:35:07 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> Since skb_checksum_help has been using pskb_expand_head for a while
> now without any ill effects, I thought it would be a good idea to
> remove the double pointers from it and its callers.
> 
> This is what the following patch does.  The only "rider" bit is the
> removal of an unnecessary BUG_ON in ip6_pkt_discard_out.  The preceding
> assignment was only added because the following function oopsed so
> there is no point in doing BUG_ON.
> 
> Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Looks great, patch applied.

It looks like this makes a few netfilter paths no longer
need a **pskb anymore as well.  Folks can feel free to make
that simplification. :-)

Thanks Herbert.

<Prev in Thread] Current Thread [Next in Thread>