netdev
[Top] [All Lists]

Re: 2.6.9-mm1: pc_debug multiple definitions

To: Adrian Bunk <bunk@xxxxxxxxx>
Subject: Re: 2.6.9-mm1: pc_debug multiple definitions
From: mcgrof@xxxxxxxxxxxxxxxxxxxx (Luis R. Rodriguez)
Date: Sat, 23 Oct 2004 23:41:52 -0400
Cc: Andrew Morton <akpm@xxxxxxxx>, David Hinds <dahinds@xxxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041022133929.GA2831@xxxxxxxxx>
Mail-followup-to: Adrian Bunk <bunk@xxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, David Hinds <dahinds@xxxxxxxxxxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, jgarzik@xxxxxxxxx, linux-net@xxxxxxxxxxxxxxx, prism54-devel@xxxxxxxxxxx, netdev@xxxxxxxxxxx
Organization: Rutgers University Student Linux Users Group
References: <20041022032039.730eb226.akpm@xxxxxxxx> <20041022133929.GA2831@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Fri, Oct 22, 2004 at 03:39:29PM +0200, Adrian Bunk wrote:
> 
> The following compile error comes from Linus' tree:
> 
> 
> <--  snip  -->
> 
> ...
>   LD      drivers/built-in.o
> drivers/pcmcia/built-in.o(.bss+0xf20): multiple definition of `pc_debug'
> drivers/net/built-in.o(.data+0x24ae0): first defined here
> make[1]: *** [drivers/built-in.o] Error 1
> 
> <--  snip  -->
> 
> 
> The pc_debug in drivers/pcmcia/ds.c was made non-static in Linus' tree,
> but the global definition of a global variable with such a generic name 
> in drivers/net/wireless/prism54/islpci_mgt.c seems to be equally wrong.

Great, anyone know why this change was done on ds.c ? The pc_debug on
prism54 comes from the original Intersil driver. It is used to for
debugging but we should move away from our current debugging mechanism
to netif_msg.

Margit, do you have some pending commits left? Do you want to take a
stab at this? If not I can later on this week.

        Luis

-- 
GnuPG Key fingerprint = 113F B290 C6D2 0251 4D84  A34A 6ADD 4937 E20A 525E

<Prev in Thread] Current Thread [Next in Thread>