netdev
[Top] [All Lists]

Re: [PATCH] use mmiowb in tg3.c

To: Jesse Barnes <jbarnes@xxxxxxxxxxxx>
Subject: Re: [PATCH] use mmiowb in tg3.c
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Thu, 21 Oct 2004 16:40:07 -0700
Cc: akpm@xxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx, gnb@xxxxxxx, akepner@xxxxxxx
In-reply-to: <200410211628.06906.jbarnes@xxxxxxxxxxxx>
References: <200410211613.19601.jbarnes@xxxxxxxxxxxx> <200410211628.06906.jbarnes@xxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Thu, 21 Oct 2004 16:28:06 -0700
Jesse Barnes <jbarnes@xxxxxxxxxxxx> wrote:

> This patch originally from Greg Banks.  Some parts of the tg3 driver depend 
> on 
> PIO writes arriving in order.  This patch ensures that in two key places 
> using the new mmiowb macro.  This not only prevents bugs (the queues can be 
> corrupted), but is much faster than ensuring ordering using PIO reads (which 
> involve a few round trips to the target bus on some platforms).

Do other PCI systems which post PIO writes also potentially reorder
them just like this SGI system does?  Just trying to get this situation
straight in my head.


<Prev in Thread] Current Thread [Next in Thread>