netdev
[Top] [All Lists]

Re: [PATCH] Make netif_rx_ni preempt-safe

To: Lee Revell <rlrevell@xxxxxxxxxxx>
Subject: Re: [PATCH] Make netif_rx_ni preempt-safe
From: Denis Vlasenko <vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Oct 2004 22:14:31 +0300
Cc: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>, Andrew Morton <akpm@xxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxxxxxx, maxk@xxxxxxxxxxxx, irda-users@xxxxxxxxxxxxxxxxxxxxx, Linux Network Development <netdev@xxxxxxxxxxx>, Alain Schroeder <alain@xxxxxxxxxxxxxxx>
In-reply-to: <1098290858.1429.70.camel@xxxxxxxxxxxxxxxx>
References: <1098230132.23628.28.camel@xxxxxxxxxxxxxxxx> <200410201811.44419.vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx> <1098290858.1429.70.camel@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: KMail/1.5.4
On Wednesday 20 October 2004 19:47, Lee Revell wrote:
> On Wed, 2004-10-20 at 11:11, Denis Vlasenko wrote:
> > 0x57 == 87 bytes is too big for inline.
> 
> Ugh.  So the only fix is not to inline it?

Yes.

You can make it conditionally inline/non-inline
depending on SMP/preempt if you feel masochistic today :),
but last time I asked davem thought that it is over the top.

Deinline it.
--
vda


<Prev in Thread] Current Thread [Next in Thread>