Re: [PATCH] Change masquerade code to use first IP address of interface.

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Wed, Oct 20, 2004 at 11:24:17AM +0200, Henrik Nordstrom wrote:
> On Wed, 20 Oct 2004, Herbert Xu wrote:
> 
> >Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
> >>
> >>+       newsrc = inet_select_addr(out, 0, RT_SCOPE_UNIVERSE);
> >>+       if (!newsrc) {
> >>+               printk("MASQUERADE: %s ate my IP address\n", out->name);
> >>+               return NF_DROP;
> >
> >Wouldn't it be better to select the address for the gateway that we're
> >sending towards?
> 
> What you mean?

I mean

        rt = (struct rtable *)(*pskb)->dst;
        newsrc = inet_select_addr(out, rt->rt_gateway, RT_SCOPE_UNIVERSE);

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt