netdev
[Top] [All Lists]

Re: [PATCH] Change masquerade code to use first IP address of interface.

To: rusty@xxxxxxxxxxxxxxx (Rusty Russell)
Subject: Re: [PATCH] Change masquerade code to use first IP address of interface.
From: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Date: Wed, 20 Oct 2004 18:32:50 +1000
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, netfilter-devel@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1098241135.10571.19.camel@xxxxxxxxxxxxxxxxxxxxx>
Organization: Core
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.4.27-hx-1-686-smp (i686))
Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote:
>
> +       newsrc = inet_select_addr(out, 0, RT_SCOPE_UNIVERSE);
> +       if (!newsrc) {
> +               printk("MASQUERADE: %s ate my IP address\n", out->name);
> +               return NF_DROP;

Wouldn't it be better to select the address for the gateway that we're
sending towards?

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

<Prev in Thread] Current Thread [Next in Thread>