| To: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: r8169: page allocation failure |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Tue, 19 Oct 2004 22:30:29 -0700 |
| Cc: | romieu@xxxxxxxxxxxxx, jkillius@xxxxxxxx, netdev@xxxxxxxxxxx, jgarzik@xxxxxxxxx |
| In-reply-to: | <20041017090837.GA24362@xxxxxxxxxxxxxxxxxxx> |
| References: | <20041016204848.GB21849@xxxxxxxxxxxxxxxxxxxxxxxxxx> <E1CJ5lg-0005eC-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041017090837.GA24362@xxxxxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sun, 17 Oct 2004 19:08:37 +1000 Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote: > On Sun, Oct 17, 2004 at 05:47:52PM +1000, Herbert Xu wrote: > > > > It should instead allocate a new skb of 1 mss. I'll work on it. > > In fact it was allocating space that it wasn't even using :) > > The following patch makes it allocate skb_headlen(skb) - len instead > of skb->len - len. When skb is linear there is no difference. When > it's non-linear we only ever copy the bytes in the header. > > Please let me know whether this fixes your problem. Looks great, good catch. Patch applied. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [RFC] Yield in netlink_broadcast when congested, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2.6] Re: xfrm_user.c doesn't use NLMSG_F_MULTI, David S. Miller |
| Previous by Thread: | Re: r8169: page allocation failure, Jan Killius |
| Next by Thread: | sk98lin: page allocation error too, Jan Killius |
| Indexes: | [Date] [Thread] [Top] [All Lists] |