| To: | Lee Revell <rlrevell@xxxxxxxxxxx> |
|---|---|
| Subject: | Re: tun.c patch to fix "smp_processor_id() in preemptible code" |
| From: | Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> |
| Date: | Wed, 20 Oct 2004 07:54:01 +1000 |
| Cc: | vda@xxxxxxxxxxxxxxxxxxxxxxxxxxxxxx, Linux Network Development <netdev@xxxxxxxxxxx>, linux-kernel <linux-kernel@xxxxxxxxxxxxxxx> |
| In-reply-to: | <1098222676.23367.18.camel@xxxxxxxxxxxxxxxx> |
| References: | <E1CK1e6-0004F3-00@xxxxxxxxxxxxxxxxxxxxxxxx> <1098222676.23367.18.camel@xxxxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
| User-agent: | Mutt/1.5.6+20040722i |
On Tue, Oct 19, 2004 at 05:51:17PM -0400, Lee Revell wrote: > > Ok, here is the correct patch. If this is really just a matter of > performance, and not required for correctness, disabling preemption is > broken, right? No if you're doing this then you should get rid of netif_rx_ni() altogether. But before you do that please ask all the people who call it. -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: tun.c patch to fix "smp_processor_id() in preemptible code", Lee Revell |
|---|---|
| Next by Date: | [PATCH 2.6.9] skge: netpoll support, Michal Schmidt |
| Previous by Thread: | Re: tun.c patch to fix "smp_processor_id() in preemptible code", Lee Revell |
| Next by Thread: | Re: tun.c patch to fix "smp_processor_id() in preemptible code", Lee Revell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |