netdev
[Top] [All Lists]

Re: [PATCH 2.6.9 2/3] tlan: inline functions should be static + bogus xo

To: Stephen Hemminger <shemminger@xxxxxxxx>
Subject: Re: [PATCH 2.6.9 2/3] tlan: inline functions should be static + bogus xor
From: Thomas Graf <tgraf@xxxxxxx>
Date: Tue, 19 Oct 2004 02:38:16 +0200
Cc: Jeff Garzik <jgarzik@xxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20041018140610.6edf1769@xxxxxxxxxxxxxxxxx>
References: <20041018140610.6edf1769@xxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
> -     return ( ( a && ! b ) || ( ! a && b ) );
> +     return a ^ b;

Did you notice that this leads to a different result if a
or b is greater than 1. Intended?

<Prev in Thread] Current Thread [Next in Thread>