netdev
[Top] [All Lists]

[PATCH 2.6] Re: xfrm_user.c doesn't use NLMSG_F_MULTI

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: [PATCH 2.6] Re: xfrm_user.c doesn't use NLMSG_F_MULTI
From: Harald Welte <laforge@xxxxxxxxxxxx>
Date: Fri, 15 Oct 2004 21:14:44 +0200
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041014110742.GA7910@xxxxxxxxxxxxxxxxxxx>
References: <20041013080705.GB3387@xxxxxxxxxxxxxxxxxxxxxxxxxx> <E1CI2I2-0001sI-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20041014105757.GB12694@xxxxxxxxxxxxxxxxxxxxxxxxxx> <20041014110742.GA7910@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Thu, Oct 14, 2004 at 09:07:42PM +1000, Herbert Xu wrote:
> On Thu, Oct 14, 2004 at 12:57:57PM +0200, Harald Welte wrote:
> > 
> > Ok, would you like to receive a patch that fixes the xfrm netlink
> > interface to be more compatible with the netlink manpage and what
> > rtnetlink does?
> 
> I have no objections at all :)
> 
> While you're at it please fix the other netlink users as well, e.g.,
> tcp_diag.

I did a short grep for netlink_dump and the only two places where
F_MULTI wasn't used was tcp_diag.c and xfrm_user.c.  Please let me know
if you know any other cases.

Pleae find a proposed patch attached to this email.  I didn't have the
means to test it at this point, though.. but it's pretty
straightforward.  Please consider applying it...

-- 
- Harald Welte <laforge@xxxxxxxxxxxx>               http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

Attachment: 2.6.9-rc3-bk9-netlink_f_multi.patch
Description: Text document

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>