Re: [PATCH 2.6.9-rc2 3/8] S2io: optimizations

[Jeff Garzik <jgarzik@xxxxxxxxx>]

Ravinandan Arakali wrote:
> Hi,
> Following are the optimization-related changes made in this patch.

No objections to this patch, but did I miss a description of the 
following change?
> -       if ((sp->pkt_cnt[ring] - rxb_size) > 128) {
> +       if ((sp->pkt_cnt[ring] - rxb_size) > 16) {
>                 level = LOW;
> -               if (rxb_size < sp->pkt_cnt[ring] / 8)
> +               if ((sp->pkt_cnt[ring] - rxb_size) < MAX_RXDS_PER_BLOCK) {
>                         level = PANIC;
> +               }
>         }