netdev
[Top] [All Lists]

Re: xfrm_user.c doesn't use NLMSG_F_MULTI

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: xfrm_user.c doesn't use NLMSG_F_MULTI
From: Harald Welte <laforge@xxxxxxxxxxxx>
Date: Thu, 14 Oct 2004 12:57:57 +0200
Cc: netdev@xxxxxxxxxxx
In-reply-to: <E1CI2I2-0001sI-00@xxxxxxxxxxxxxxxxxxxxxxxx>
References: <20041013080705.GB3387@xxxxxxxxxxxxxxxxxxxxxxxxxx> <E1CI2I2-0001sI-00@xxxxxxxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040722i
On Thu, Oct 14, 2004 at 07:52:54PM +1000, Herbert Xu wrote:
> Harald Welte <laforge@xxxxxxxxxxxx> wrote:
> > 
> > If I send a GETSA with NLM_F_DUMP message from userspace, I receive a
> > batch of SA messages, but they apparently don't have the F_MULTI flag
> > set. 
> > 
> > Aren't they (all but the last msg) supposed to have the usual F_MULTI ?
> > Is this by intention or a mistake?
> 
> The documentation says so but none of the existing users really care.

Well, people are developing more users, you know ;)  Somebody at
Astaro (http://www.astaro.com/) is investigating the possibilities of SA
synchronization for IPsec HA, and 

> The doco also says that the DONE message shouldn't have F_MULTI set
> but it does :)

Ok, would you like to receive a patch that fixes the xfrm netlink
interface to be more compatible with the netlink manpage and what
rtnetlink does?

> Cheers,

-- 
- Harald Welte <laforge@xxxxxxxxxxxx>               http://www.gnumonks.org/
============================================================================
Programming is like sex: One mistake and you have to support it your lifetime

Attachment: signature.asc
Description: Digital signature

<Prev in Thread] Current Thread [Next in Thread>