netdev
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [PATCH] work around 5701 misalignment

from [Jeff Garzik] [Permanent Link][Original]
To: Jesse Barnes <jbarnes@xxxxxxx>
Subject: Re: [PATCH] work around 5701 misalignment
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Wed, 13 Oct 2004 16:57:28 -0400
Cc: netdev@xxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxx>
In-reply-to: <200410131554.19845.jbarnes@xxxxxxx>
References: <200410131554.19845.jbarnes@xxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922 
Jesse Barnes wrote:

--- a/linux/drivers/net/tg3.c   2004-10-13 15:25:03.000000000 -0500
+++ b/linux/drivers/net/tg3.c   2004-10-13 15:14:45.000000000 -0500
@@ -2352,7 +2352,12 @@
len = ((desc->idx_len & RXD_LEN_MASK) >> RXD_LEN_SHIFT) - 4; /* omit crc */ - if (len > RX_COPY_THRESHOLD) { 
+               if (len > RX_COPY_THRESHOLD
+#if defined(CONFIG_UNALIGNED_EXPENSIVE)
+                                && tp->rx_offset == 2
+#endif
hmmm, the normal solution is to give RX_COPY_THRESHOLD a per-arch value. Grep for 'rx_copybreak' in bunches of net drivers.
DaveM might squirm a bit but IMHO RX_COPY_THRESHOLD really is platform-dependent. 

        Jeff
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: mm kernel oops with r8169 & named, PREEMPT, Danny
Next by Date:  [PATCH] work around 5701 misalignment, Jesse Barnes
Previous by Thread:  [PATCH] work around 5701 misalignment, Jesse Barnes
Next by Thread:  Re: [PATCH] work around 5701 misalignment, David S. Miller
Indexes:  [Date] [Thread] [Top] [All Lists]