Matt Mackall wrote:
On Tue, Oct 12, 2004 at 09:39:23PM +1000, Con Kolivas wrote:
This patch adds poll support to the b44 driver to allow netconsole
support. Style lifted straight from 8139too.c
here is the dmesg output with it in place:
netconsole: device eth0 not up yet, forcing it
netconsole: carrier detect appears flaky, waiting 10 seconds
b44: eth0: Link is down.
b44: eth0: Link is up at 100 Mbps, full duplex.
b44: eth0: Flow control is on for TX and on for RX.
netconsole: network logging started
output confirmed by netcat on other system.
Signed-off-by: Con Kolivas <kernel@xxxxxxxxxxx>
+ b44_interrupt (dev->irq, dev, NULL);
Aside from this bizarre whitespace convention and neglecting to cc:
me, looks good.
Can you explain where I went wrong in the whitespace so I don't make the
same mistake again? It looked pretty standard to me.
Should I nudge akpm with this or will it go via another route?
Description: OpenPGP digital signature