[Top] [All Lists]

Re: [PATCH] netconsole support for b44

To: Matt Mackall <mpm@xxxxxxxxxxx>
Subject: Re: [PATCH] netconsole support for b44
From: Con Kolivas <kernel@xxxxxxxxxxx>
Date: Wed, 13 Oct 2004 07:48:18 +1000
Cc: netdev@xxxxxxxxxxx, linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>, davem@xxxxxxxxxx
In-reply-to: <20041012180949.GW5414@xxxxxxxxx>
References: <416BC26B.6090603@xxxxxxxxxxx> <20041012180949.GW5414@xxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla Thunderbird 0.8 (X11/20040913)
Matt Mackall wrote:
On Tue, Oct 12, 2004 at 09:39:23PM +1000, Con Kolivas wrote:

This patch adds poll support to the b44 driver to allow netconsole support. Style lifted straight from 8139too.c

here is the dmesg output with it in place:

netconsole: device eth0 not up yet, forcing it
netconsole: carrier detect appears flaky, waiting 10 seconds
b44: eth0: Link is down.
b44: eth0: Link is up at 100 Mbps, full duplex.
b44: eth0: Flow control is on for TX and on for RX.
netconsole: network logging started

output confirmed by netcat on other system.

Signed-off-by: Con Kolivas <kernel@xxxxxxxxxxx>

+       disable_irq(dev->irq);
+       b44_interrupt (dev->irq, dev, NULL);
+       enable_irq(dev->irq);

Aside from this bizarre whitespace convention and neglecting to cc:
me, looks good.


Can you explain where I went wrong in the whitespace so I don't make the same mistake again? It looked pretty standard to me.

Should I nudge akpm with this or will it go via another route?


Attachment: signature.asc
Description: OpenPGP digital signature

<Prev in Thread] Current Thread [Next in Thread>