netdev
[Top] [All Lists]

Re: [PATCH] netconsole support for b44

To: Con Kolivas <kernel@xxxxxxxxxxx>
Subject: Re: [PATCH] netconsole support for b44
From: Matt Mackall <mpm@xxxxxxxxxxx>
Date: Tue, 12 Oct 2004 13:09:49 -0500
Cc: netdev@xxxxxxxxxxx, linux kernel mailing list <linux-kernel@xxxxxxxxxxxxxxx>, davem@xxxxxxxxxx
In-reply-to: <416BC26B.6090603@xxxxxxxxxxx>
References: <416BC26B.6090603@xxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.3.28i
On Tue, Oct 12, 2004 at 09:39:23PM +1000, Con Kolivas wrote:
> This patch adds poll support to the b44 driver to allow netconsole 
> support. Style lifted straight from 8139too.c
> 
> here is the dmesg output with it in place:
> 
> netconsole: device eth0 not up yet, forcing it
> netconsole: carrier detect appears flaky, waiting 10 seconds
> b44: eth0: Link is down.
> b44: eth0: Link is up at 100 Mbps, full duplex.
> b44: eth0: Flow control is on for TX and on for RX.
> netconsole: network logging started
> 
> output confirmed by netcat on other system.
> 
> Signed-off-by: Con Kolivas <kernel@xxxxxxxxxxx>

+       disable_irq(dev->irq);
+       b44_interrupt (dev->irq, dev, NULL);
+       enable_irq(dev->irq);

Aside from this bizarre whitespace convention and neglecting to cc:
me, looks good.

-- 
Mathematics is the supreme nostalgia of our time.

<Prev in Thread] Current Thread [Next in Thread>