netdev
[Top] [All Lists]

Re: Raylink/WebGear testing - ray_cs.c iomem bug?

To: Linus Torvalds <torvalds@xxxxxxxx>
Subject: Re: Raylink/WebGear testing - ray_cs.c iomem bug?
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Wed, 6 Oct 2004 10:54:53 -0700
Cc: jgarzik@xxxxxxxxx, acme@xxxxxxxxxxxxxxxx, corey@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <Pine.LNX.4.58.0410061032410.8290@xxxxxxxxxxxxxxx>
References: <Pine.LNX.4.58.0410061032410.8290@xxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 6 Oct 2004 10:43:50 -0700 (PDT)
Linus Torvalds <torvalds@xxxxxxxx> wrote:

> That cleanup in turn seems to show that the driver was fundamentally buggy
> in a way that really surprises me: it adds "CCS_BASE" to the PCI window
> base in order to get to both the "struct ccs" pointer _and_ to the "struct
> rcs" pointer.

In the spot where this occurs, it adds both CCS_BASE and
'rcsindex' to the sram base, and only when rcsindex >= NUMBER_OF_CCS.

NUMBER_OF_CCS is 64, and the difference between CCS_BASE and RCS_BASE
is 0x400 so this really doesn't account for anything.

I can't see how you've changed the behavior, so it should work as well
as it did before your changes.

Sorry, I don't have a ray_cs handy :)

<Prev in Thread] Current Thread [Next in Thread>