netdev
[Top] [All Lists]

Re: PATCH: [SKBUFF] Introduce skb_set_link_header_offset(skb, offset)

To: Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx>
Subject: Re: PATCH: [SKBUFF] Introduce skb_set_link_header_offset(skb, offset)
From: "David S. Miller" <davem@xxxxxxxxxx>
Date: Tue, 5 Oct 2004 13:53:38 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <4162FF64.4050108@xxxxxxxxxxxxxxxx>
References: <4162FF64.4050108@xxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Tue, 05 Oct 2004 17:09:08 -0300
Arnaldo Carvalho de Melo <acme@xxxxxxxxxxxxxxxx> wrote:

> Hi David,
> 
>       Please consider pulling from:
> 
> bk://kernel.bkbits.net/acme/sk_buff-2.4
> 
>       Now there are 14 outstanding changesets in this tree.

Slow down. :-)

There are bugs in your earlier changesets which are going
to make it hard for me to pull this tree in.  Let's work
one or two changesets at a time, not 14 ok? :-)

First bug, in ChangeSet 1.2032, drivers/net/wireless/orinoco.c

You change "skb->mac.raw + ETH_ALEN" into
"eth_hdr(skb)->h_source".  That can't be right
since orinoco_spy_gather() expects a pointer for
that argument.

Same error in the drivers/net/wireless/wavelan.c change
in ChangeSet 1.2032, replacing skb->mac.raw (a pointer)
with eth_hdr(skb)->h_dest in the call to wv_packet_info.
And then "skb->mac.raw + WAVELAN_ADDR_SIZE" into
"eth_hdr(skb)->h_source" in the call to wl_spy_gather().

The same errors occur all the changes to
drivers/net/wireless/wavelan_cs.c of the same ChangeSet.

Please start to submit this stuff in smaller pieces and
fix the above bugs, thanks.

<Prev in Thread] Current Thread [Next in Thread>