| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/3] NET: Generic rate estimator |
| From: | jamal <hadi@xxxxxxxxxx> |
| Date: | 04 Oct 2004 10:59:44 -0400 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041004141532.GB15898@xxxxxxxxxxxxxx> |
| Organization: | jamalopolous |
| References: | <20041003213124.GG14344@xxxxxxxxxxxxxx> <20041003213954.GI14344@xxxxxxxxxxxxxx> <20041003161436.50293f9a.davem@xxxxxxxxxxxxx> <20041003233647.GN14344@xxxxxxxxxxxxxx> <1096852582.1046.378.camel@xxxxxxxxxxxxxxxx> <20041004125300.GA15898@xxxxxxxxxxxxxx> <1096896256.1072.4.camel@xxxxxxxxxxxxxxxx> <20041004141532.GB15898@xxxxxxxxxxxxxx> |
| Reply-to: | hadi@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Mon, 2004-10-04 at 10:15, Thomas Graf wrote: > * jamal <1096896256.1072.4.camel@xxxxxxxxxxxxxxxx> 2004-10-04 09:24 > > What you need is to replace the HZ/4 in the creation and execution > > of the timer with a constant. And that the value of said constant would > > be preferably in the 250ms range. > > HZ/4 == 250ms works except for HZ=122 (~246ms) and HZ=50 (~240ms). is that bad to let those have a slight different innacurate value? BTW wasnt there a jiffies2ms converter somewhere that we could use? I thought i saw something posted of that nature recently. > I don't > know how you think it is possible to find a constant around 250ms which > works for all HZ values. The problem gets even minor if we do > (HZ<<idx)/4 instead of (HZ/4)<<idx in which the inaccuracy only happens > if idx is 0, i.e. interval == -2. There should really be no difference between the two;-> you realize /4 is merely <<2 ? cheers, jamal |
| Previous by Date: | PATCH: [SKBUFF] introduce ax25_type_trans, Arnaldo Carvalho de Melo |
|---|---|
| Next by Date: | PATCH: [SKBUFF] introduce irda_type_trans, Arnaldo Carvalho de Melo |
| Previous by Thread: | Re: [PATCH 2/3] NET: Generic rate estimator, Thomas Graf |
| Next by Thread: | Re: [PATCH 2/3] NET: Generic rate estimator, Thomas Graf |
| Indexes: | [Date] [Thread] [Top] [All Lists] |