| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2/3] NET: Generic rate estimator |
| From: | jamal <hadi@xxxxxxxxxx> |
| Date: | 03 Oct 2004 21:16:22 -0400 |
| Cc: | "David S. Miller" <davem@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx |
| In-reply-to: | <20041003233647.GN14344@xxxxxxxxxxxxxx> |
| Organization: | jamalopolous |
| References: | <20041003213124.GG14344@xxxxxxxxxxxxxx> <20041003213954.GI14344@xxxxxxxxxxxxxx> <20041003161436.50293f9a.davem@xxxxxxxxxxxxx> <20041003233647.GN14344@xxxxxxxxxxxxxx> |
| Reply-to: | hadi@xxxxxxxxxx |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sun, 2004-10-03 at 19:36, Thomas Graf wrote: > * David S. Miller <20041003161436.50293f9a.davem@xxxxxxxxxxxxx> 2004-10-03 > 16:14 > > > +#if (HZ%4) != 0 > > > +#error Bad HZ value. > > > +#endif > > > > This is going to fail to compile on a few platforms, namely m68knommu > > and v850 which have configurations that result in using a HZ value > > of 50 and 122 respectively. > > This was taken over from net/sched/estimator.c so I guess there was no > person ever using the rate estimator on such an arch ;) > > Can we simply remove the check? The granularity of the timing is dependent on this - 250msec increments. Find a common demonitor for all Hz values which results in something along 200ms range and we should be set. cheers, jamal |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2/3] NET: Generic rate estimator, Thomas Graf |
|---|---|
| Next by Date: | PATCH: [SKBUFF] introduce x25_type_trans, Arnaldo Carvalho de Melo |
| Previous by Thread: | Re: [PATCH 2/3] NET: Generic rate estimator, Thomas Graf |
| Next by Thread: | Re: [PATCH 2/3] NET: Generic rate estimator, Thomas Graf |
| Indexes: | [Date] [Thread] [Top] [All Lists] |