netdev
[Top] [All Lists]

Re: [PATCH] 802.1Q VLAN

To: "David S. Miller" <davem@xxxxxxxxxxxxx>
Subject: Re: [PATCH] 802.1Q VLAN
From: Ben Greear <greearb@xxxxxxxxxxxxxxx>
Date: Wed, 27 Oct 2004 18:28:21 -0700
Cc: netdev@xxxxxxxxxxx
In-reply-to: <20041027164912.09cc63f8.davem@davemloft.net>
Organization: Candela Technologies
References: <41797696.9070905@candelatech.com> <20041022214611.GA4948@electric-eye.fr.zoreil.com> <41798506.1030909@candelatech.com> <417D675F.3000909@candelatech.com> <417D929A.2090809@candelatech.com> <20041027164912.09cc63f8.davem@davemloft.net>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913
David S. Miller wrote:
On Mon, 25 Oct 2004 16:56:10 -0700
Ben Greear <greearb@xxxxxxxxxxxxxxx> wrote:


DaveM, please consider accepting this patch (it's in a previous email to netdev,
just ask if you want it re-sent.)


Applied, but I had to apply it by hand.  It gave a large reject.
For some reason, patch barfed at the end of the vlan_dev.c parts
and refused to interpreter the parts of the diffs for the other
files.

Did you try to apply that patch to a tree before sending it off?

Anyways, I put it in by hand nevertheless.

I appreciate it. I had edited the original patch, removing some diffs of files that were not vlan related. I guess that doesn't work so well. Will be more careful next time.


Also, what is up with the magic "23" constant in the get realdev name function strncpy() call?

Well, the fields are 24-bytes long, as defined in the include/linux/if_vlan.h file. I could change it to a #define and/or use sizeof if you prefer.

Thanks,
Ben

--
Ben Greear <greearb@xxxxxxxxxxxxxxx>
Candela Technologies Inc  http://www.candelatech.com


<Prev in Thread] Current Thread [Next in Thread>