netdev
[Top] [All Lists]

Re: [PATCH] Add ability to register class interfaces for network class

To: ext Christoph Hellwig <hch@xxxxxxxxxxxxx>
Subject: Re: [PATCH] Add ability to register class interfaces for network class
From: "Teras Timo (EXT-YomiGroup/Helsinki)" <Ext-Timo.Teras@xxxxxxxxx>
Date: Tue, 26 Oct 2004 23:52:39 +0300
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20041026184838.GB16621@infradead.org>
References: <20041026183526.GA23535@two.research.nokia.com> <20041026184838.GB16621@infradead.org>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
On Tue, Oct 26, 2004 at 07:48:38PM +0100, ext Christoph Hellwig wrote:
> On Tue, Oct 26, 2004 at 09:35:26PM +0300, Timo Teräs wrote:
> > Add functions to register class interfaces for network class.
> > Similar to the ones found in scsi subsystem.
> > 
> > Originally posted on linux-net and related discussion can be found
> > from http://marc.theaimsgroup.com/?l=linux-net&m=109758592121767&w=2.
> > 
> > Signed-off-by: Timo Teräs <ext-timo.teras@xxxxxxxxx>
> 
> And you still haven't told why this makes sense nor shown a user for it.

Did you read my original reply to your earlier mail?

I pointed out the reason why I need it: to add an attribute:
/sys/class/net/<interface>/<new_attribute>. Others might want to do this
too.

Also the interface subsystem is used in many places (eg. i2o) to create
all the sysfs entries. Maybe it'd be useful to do in net class as well.
And if'd make separate interfaces for standard attributes and wireless
attributes. That way you'd get rid of the #ifdefs of WIRELESS_EXT in
net-sysfs.c.

On the other hand you didn't answer my question: why the
interface registration should not be possible?
Documentation/driver-model/interface.txt states that this is exactly the
thing it should be used for.

Regards,
  Timo


<Prev in Thread] Current Thread [Next in Thread>