[Top] [All Lists]

Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode

To: ravinandan.arakali@xxxxxxxx
Subject: Re: [PATCH 2.6.9-rc2 8/8] S2io: two buffer mode
From: Jeff Garzik <jgarzik@xxxxxxxxx>
Date: Thu, 14 Oct 2004 11:03:44 -0400
Cc: "'Francois Romieu'" <romieu@xxxxxxxxxxxxx>, netdev@xxxxxxxxxxx, leonid.grossman@xxxxxxxx, raghavendra.koushik@xxxxxxxx, rapuru.sriram@xxxxxxxx
In-reply-to: <005a01c4b18b$c1fd7400$>
References: <005a01c4b18b$c1fd7400$>
Sender: netdev-bounce@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040922
no objections but two comments:

1) can this not be done with SKB fragments?

2) the following code needlessly uses GFP_ATOMIC:

+                               ba = &nic->ba[i][j][k];
+                               ba->ba_0_org = (void *) kmalloc
+                                   (BUF0_LEN + ALIGN_SIZE, GFP_ATOMIC);

and there is another example just a bit down from that one.

<Prev in Thread] Current Thread [Next in Thread>