Re: bad TSO performance in 2.6.9-rc2-BK

[Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>]

On Wed, Sep 29, 2004 at 09:33:10PM -0700, David S. Miller wrote:
>
> @@ -2413,7 +2410,7 @@
>                                                       packets_acked);
>                       if (sacked & TCPCB_URG) {
>                               if (tp->urg_mode &&
> -                                 !before(scb->seq, tp->snd_up))
> +                                 !before(orig_seq, tp->snd_up))
>                                       tp->urg_mode = 0;

That looks like a typo.  We should check against the new starting
sequence number, not the original.  We should also change the !before
to after since the original check applied to end_seq.

Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>

Cheers,
-- 
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

p
Description: Text document