Re: RFC/PATCH capture qdisc requeue event in stats

[jamal <hadi@xxxxxxxxxx>]

On Tue, 2004-09-28 at 20:36, Thomas Graf wrote:
> * David S. Miller <20040830212910.78047bcd.davem@xxxxxxxxxxxxx> 2004-08-30 
> 21:29
> > Look, let's get real about this topic.  We can't be breaking shit
> > like this all the time.  We're nearly letting it happen a lot
> > lately.
> > 
> > These data structures are user visible APIs, they are just like
> > system call data structures, and if we cannot modify
> > them without potentially breaking some existing application we
> > cannot make that change.
> 
> Why not do it by using nested TLVs?:
> 
>   TCA_STATS2 [
>       TCA_STAT_BYTES
>       TCA_STAT_PACKETS
>       TCA_STAT_DROPS
>       ...
>   ]

Refer to my earlier email; i think this is a noble approach.
Lets do it on gnet stats though so we can make it more accessible.
I think your granularity maybe too thin: bytes,packets, drops
may need to be in the same TLV.

> This way we can add as many new stats as we want without
> even thinking about backward compatibility in the future.
> This would also allow to implement dynamic size statistics
> or introduce TCA_STAT_*_64 if ever needed.

Yep.
do you have cycles to run with that patch?

cheers,
jamal