netdev
[Top] [All Lists]

Re: [PATCH][ATM]: [drivers] use msleep() instead of schedule_timeout() (

To: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Subject: Re: [PATCH][ATM]: [drivers] use msleep() instead of schedule_timeout() (from Nishanth Aravamudan <nacc@xxxxxxxxxx>)
From: "chas williams (contractor)" <chas@xxxxxxxxxxxxxxxx>
Date: Thu, 23 Sep 2004 12:26:05 -0400
Cc: netdev@xxxxxxxxxxx, davem@xxxxxxxxxx, kernel-janitors@xxxxxxxxxxxxxx
In-reply-to: Message from Nishanth Aravamudan <nacc@xxxxxxxxxx> of "Thu, 23 Sep 2004 09:07:10 PDT." <20040923160710.GB1699@xxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
oops. sorry about that.  dave, please apply the following patch.

thanks!

# This is a BitKeeper generated diff -Nru style patch.
#
# ChangeSet
#   2004/09/23 12:24:28-04:00 chas@xxxxxxxxxxxxxxxxxxxxxx 
#   [ATM]: [lanai] get sleep interval right
# 
# drivers/atm/lanai.c
#   2004/09/23 12:24:12-04:00 chas@xxxxxxxxxxxxxxxxxxxxxx +1 -1
#   [ATM]: [lanai] get sleep interval right
# 
diff -Nru a/drivers/atm/lanai.c b/drivers/atm/lanai.c
--- a/drivers/atm/lanai.c       2004-09-23 12:25:36 -04:00
+++ b/drivers/atm/lanai.c       2004-09-23 12:25:36 -04:00
@@ -813,7 +813,7 @@
                        DPRINTK("read, write = %d, %d\n", read, write);
                        break;
                }
-               msleep(4);
+               msleep(40);
        }
        /* 15.2.2 - clear out all tx registers */
        cardvcc_write(lvcc, 0, vcc_txreadptr);

In message <20040923160710.GB1699@xxxxxxxxxx>,Nishanth Aravamudan writes:
>On Tue, Sep 21, 2004 at 04:29:19PM -0400, chas williams (contractor) wrote:
>
><snip>
>> diff -Nru a/drivers/atm/lanai.c b/drivers/atm/lanai.c
>> --- a/drivers/atm/lanai.c    2004-09-21 12:48:17 -04:00
>> +++ b/drivers/atm/lanai.c    2004-09-21 12:48:17 -04:00
>> @@ -813,7 +813,7 @@
>>                      DPRINTK("read, write = %d, %d\n", read, write);
>>                      break;
>>              }
>> -            schedule_timeout(HZ / 25);
>> +            msleep(4);
>
>Somehow this got changed for msleep(40); to msleep(4); !! :) The patch I
>sent on 15 September had msleep(40); in it, at least. If you could make
>the change in your bk, that would be great!
>
>-Nish
>

<Prev in Thread] Current Thread [Next in Thread>