netdev
[Top] [All Lists]

Re: msleep changes

To: Nishanth Aravamudan <nacc@xxxxxxxxxx>
Subject: Re: msleep changes
From: margitsw@xxxxxxxxxxx (Margit Schubert-While)
Date: Thu, 23 Sep 2004 05:24:33 +0200
Cc: davem@xxxxxxxxxxxxx, netdev@xxxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
Hi Nish,
In latest BK :

# drivers/atm/lanai.c
# 2004/09/21 14:58:17-07:00 chas@xxxxxxxxxxxxxxxx +1 -1
# [ATM]: [drivers] Use msleep() instead of schedule_timeout()
# From Nishanth Aravamudan <nacc@xxxxxxxxxx>

diff -Nru a/drivers/atm/lanai.c b/drivers/atm/lanai.c
--- a/drivers/atm/lanai.c       2004-09-21 17:11:30 -07:00
+++ b/drivers/atm/lanai.c       2004-09-21 17:11:30 -07:00
@@ -813,7 +813,7 @@
                        DPRINTK("read, write = %d, %d\n", read, write);
                        break;
                }
-               schedule_timeout(HZ / 25);
+               msleep(4);


??????

Just one that immediately lept to my eye.
I am not going to check them all.
That's your job :-)

These msleep(_interruptible) changes have been tested or ?

Margit



<Prev in Thread] Current Thread [Next in Thread>