| To: | Thomas Graf <tgraf@xxxxxxx> |
|---|---|
| Subject: | Re: [PATCH 2.6 NET] Fix ifmap alignment issues over rtnetlink |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Tue, 21 Sep 2004 17:21:26 -0700 |
| Cc: | netdev@xxxxxxxxxxx |
| In-reply-to: | <20040922000325.GN566@xxxxxxxxxxxxxx> |
| References: | <20040921224127.GM566@xxxxxxxxxxxxxx> <20040921165733.3e0d31d8.davem@xxxxxxxxxxxxx> <20040922000325.GN566@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Wed, 22 Sep 2004 02:03:25 +0200 Thomas Graf <tgraf@xxxxxxx> wrote: > * David S. Miller <20040921165733.3e0d31d8.davem@xxxxxxxxxxxxx> 2004-09-21 > 16:57 > > On Wed, 22 Sep 2004 00:41:27 +0200 > > Thomas Graf <tgraf@xxxxxxx> wrote: > > > > > + k_map.mem_start = (unsigned long) u_map->mem_start; > > > + k_map.mem_end = (unsigned long) u_map->mem_end; > > > + k_map.base_addr = (unsigned short) u_map->base_addr; > > > + k_map.irq = (unsigned char) u_map->irq; > > > + k_map.dma = (unsigned char) u_map->dma; > > > + k_map.port = (unsigned char) u_map->port; > > > > Please cast to the actual types that struct ifmap uses, > > otherwise the change is OK. > > It is or am I missing something? I'm retarded and I was looking at the wrong structure definition, sorry. Please resend your patch to me via private email and I'll add it to my tree, thanks Thomas. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH] Improve behaviour of Netlink Sockets, Herbert Xu |
|---|---|
| Next by Date: | Re: [PATCH] Improve behaviour of Netlink Sockets, Pablo Neira |
| Previous by Thread: | Re: [PATCH 2.6 NET] Fix ifmap alignment issues over rtnetlink, Thomas Graf |
| Next by Thread: | Re: [PATCH 2.6 NET] Fix ifmap alignment issues over rtnetlink, Herbert Xu |
| Indexes: | [Date] [Thread] [Top] [All Lists] |