netdev
[Top] [All Lists]

Re: [PATCH] Improve behaviour of Netlink Sockets

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [PATCH] Improve behaviour of Netlink Sockets
From: jamal <hadi@xxxxxxxxxx>
Date: 21 Sep 2004 07:47:45 -0400
Cc: Pablo Neira <pablo@xxxxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxx>, netdev@xxxxxxxxxxx
In-reply-to: <20040920215906.GA26266@xxxxxxxxxxxxxxxxxxx>
Organization: jamalopolous
References: <E1C8way-0000aH-00@xxxxxxxxxxxxxxxxxxxxxxxx> <20040919120249.GA5963@xxxxxxxxxxxxxxxxxxx> <414DF11C.1080505@xxxxxxxxxxx> <20040919215915.GB9573@xxxxxxxxxxxxxxxxxxx> <1095633569.1047.107.camel@xxxxxxxxxxxxxxxx> <20040919231734.GA10124@xxxxxxxxxxxxxxxxxxx> <1095647944.1046.206.camel@xxxxxxxxxxxxxxxx> <20040920025802.GA11567@xxxxxxxxxxxxxxxxxxx> <1095683660.1047.254.camel@xxxxxxxxxxxxxxxx> <414F1E12.6010808@xxxxxxxxxxx> <20040920215906.GA26266@xxxxxxxxxxxxxxxxxxx>
Reply-to: hadi@xxxxxxxxxx
Sender: netdev-bounce@xxxxxxxxxxx
On Mon, 2004-09-20 at 17:59, Herbert Xu wrote:

> > jamal wrote:
> >
> > >Agreed.
> > >For a test i typically have something adding say 10K items (actions in
> > >my case, but could be ipsec policies) and then try to dump them. On my
> > >xeon i get an overrun after about 6K items are dumped.
> 
> Good.  That's something we can look at easily.  Dumping is meant to
> be self-controlling as each packet naturally stops the next one from
> being sent until the user has done a recvmsg.

A get which results in a huge response (cant think of anything that
fits there - I have some stuff i havent released yet which applies) will
also have the same. Note by "large" implies it will overflow socket
buffer (and a setsock to increase the size will delay the problem from
happening).
Note, that an overrun in a dump results in lost messages. Maybe we can
detect that and reset the cb pointers appropriately? Have to look at the
code.

cheers,
jamal


<Prev in Thread] Current Thread [Next in Thread>