netdev
[Top] [All Lists]

Re: [RTNETLINK] Convert RTM_* to enum

To: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [RTNETLINK] Convert RTM_* to enum
From: "David S. Miller" <davem@xxxxxxxxxxxxx>
Date: Tue, 14 Sep 2004 21:46:52 -0700
Cc: jmorris@xxxxxxxxxx, yoshfuji@xxxxxxxxxxxxxx, netdev@xxxxxxxxxxx
In-reply-to: <20040915044555.GA1323@xxxxxxxxxxxxxxxxxxx>
References: <20040915020942.GA32721@xxxxxxxxxxxxxxxxxxx> <Xine.LNX.4.44.0409142337130.28280-100000@xxxxxxxxxxxxxxxxxxxxxxxx> <20040915034748.GA952@xxxxxxxxxxxxxxxxxxx> <20040914213837.75634b93.davem@xxxxxxxxxxxxx> <20040915044555.GA1323@xxxxxxxxxxxxxxxxxxx>
Sender: netdev-bounce@xxxxxxxxxxx
On Wed, 15 Sep 2004 14:45:55 +1000
Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> wrote:

> On Tue, Sep 14, 2004 at 09:38:37PM -0700, David S. Miller wrote:
> > 
> > Right.  If we start using defines we have to keep them around.
> > I know it's bogus for people to ifdef this stuff, but we know
> > they do, and it's in bad taste to knowingly break stuff like that.
> 
> How about if we make it a rule that we only add new enum constants
> but not macros?

If you create some new enumeration from scratch, sure, but
for existing ones no.

<Prev in Thread] Current Thread [Next in Thread>