Hi:
This patch adds a new flags field to struct ip_tunnel_parm.
The reason is that one of its users, ip_gre cannot place any new flags
in the existing fields. i_flags is unuseable for GRE because any future
GRE extension may use one of those bits.
Of course we'll need new flags to implement the DSCP options as we
did for ip6_tunnel.
Signed-off-by: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
BTW if anyone else wants to add more fields to the structure, now is
the time.
Another thing, the iptnl_* functions turn out to be fairly big.
So I'd like to uninline them. Unfortunately I can't think of a
good place to put them.
Should I:
1) Put it into ipip.c and make the others depend on it.
2) Put it into xfrm4_tunnel.c and make the others depend on it.
3) Put it into some other file in net/ipv4 that's always built in.
4) Create a new module just for this (and any other shared code between them).
5) Replace inline with __attribute__ ((__unused__)).
6) Stop thinking about this and do something useful :)
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
p
Description: Text document
|