| To: | Eric Lemoine <eric.lemoine@xxxxxxxxx> |
|---|---|
| Subject: | Re: [PATCH] LLTX for tg3 |
| From: | "David S. Miller" <davem@xxxxxxxxxxxxx> |
| Date: | Sun, 12 Sep 2004 16:45:16 -0700 |
| Cc: | ak@xxxxxxx, davem@xxxxxxxxxx, netdev@xxxxxxxxxxx |
| In-reply-to: | <5cac192f040912100616feb28a@xxxxxxxxxxxxxx> |
| References: | <20040907121841.GA4398@xxxxxxxxxxxxx> <5cac192f040912100616feb28a@xxxxxxxxxxxxxx> |
| Sender: | netdev-bounce@xxxxxxxxxxx |
On Sun, 12 Sep 2004 19:06:26 +0200 Eric Lemoine <eric.lemoine@xxxxxxxxx> wrote: > > Add LLTX suppor to tg3. Locking was already safe for it, so only > > trivial changes. > > tg3_set_rx_mode() (dev->set_multicast_list()) and tg3_start_xmit() > used to synchronise thanks to dev->lock_xmit. With your LLTX patches > they don't synchronise anymore (I don't think tg3_set_rx_mode() grabs > tp->tx_lock) ; isn't it an issue? You're absolutely right, I've made tg3_set_rx_mode() grab the tx_lock now too. Good spotting Eric. |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [PATCH 2.6] ipvs - v2: do not use skb_checksum_help, nf_reset, David S. Miller |
|---|---|
| Next by Date: | Re: [PATCH 2.6] ip_nat_ftp - manip at the right place, David S. Miller |
| Previous by Thread: | Re: [PATCH] LLTX for tg3, Eric Lemoine |
| Next by Thread: | [PATCH] Compat32 setsockopt overzealous conversions, David Woodhouse |
| Indexes: | [Date] [Thread] [Top] [All Lists] |